Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update README.md with contribution call #34

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

docs: Update README.md with contribution call #34

wants to merge 3 commits into from

Conversation

PhilinTv
Copy link
Contributor

@PhilinTv PhilinTv commented Jun 13, 2024 •
edited
Loading

Contribution call.

@PhilinTv PhilinTv requested a review from a team as a code owner June 13, 2024 10:47
@PhilinTv PhilinTv added the documentation Improvements or additions to documentation label Jun 13, 2024
PhilinTv
PhilinTv commented Jun 13, 2024
View reviewed changes
README.md Show resolved Hide resolved
tolerants
tolerants reviewed Jun 13, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@tolerants
Copy link
Contributor

tolerants commented Jun 13, 2024 •
edited
Loading

It looks more like a docs commit type for me, not chore.
Also whe shouldn't put BREAKING CHANGE line in case there are no breaking changes as long as automation will detect it and threats this change as a Major.

@PhilinTv PhilinTv mentioned this pull request Jun 14, 2024
Closed
@PhilinTv @tolerants
Update README.md
f9251bb 
Co-authored-by: Alexander Kovalenko <[email protected]>
@PhilinTv PhilinTv changed the title chore: Update README.md with contribution call docs: Update README.md with contribution call Jun 17, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 17, 2024 •
edited
Loading

✅ Deploy Preview for dev-composable-storefront canceled.

Name Link
🔨 Latest commit f9251bb
🔍 Latest deploy log https://app.netlify.com/sites/dev-composable-storefront/deploys/667005ebb545bc00087ffe0c

@netlify Netlify
Copy link

netlify bot commented Jun 17, 2024 •
edited
Loading

✅ Deploy Preview for dev-oryx-components canceled.

Name Link
🔨 Latest commit f9251bb
🔍 Latest deploy log https://app.netlify.com/sites/dev-oryx-components/deploys/667005ebf36edd000806b167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolerants tolerants tolerants approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.5 - Public Open Source release
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilinTv @tolerants